Make an empty DiffSync instance evaluate to True.#114
Closed
Kircheneer wants to merge 10 commits intonext-2.0from
Closed
Make an empty DiffSync instance evaluate to True.#114Kircheneer wants to merge 10 commits intonext-2.0from
Kircheneer wants to merge 10 commits intonext-2.0from
Conversation
Collaborator
|
I'm curious as to whether this should be considered a breaking change - i.e. are there any existing users of the library that rely on the current truthiness behavior? |
Contributor
Author
|
As discussed this really should warrant a major version increase and as such will have to be delayed until we have more breaking changes. |
added 2 commits
August 18, 2023 11:58
Migration to Pydantic v2
renames diffsync.DiffSync to diffsync.Adapter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84